Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual centering #50

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Visual centering #50

merged 2 commits into from
Sep 23, 2024

Conversation

milesagraham
Copy link
Member

updated tests to be compatible with latest changes

@milesagraham milesagraham merged commit 342b26f into main Sep 23, 2024
7 checks passed
@milesagraham milesagraham deleted the visual_centering branch September 23, 2024 11:11
@alisterburt
Copy link
Member

@milesagraham cool to see you working on this! Would it be better to make the center configurable with x/y/z values as a Tuple[int, int, int]?

@milesagraham
Copy link
Member Author

Hey Alister,

Yeah good to be working on it :D Day 1 of 3rd year begun!

Absolutely. This is my next step. Was thinking along the lines (after a useful convo with @jojoelfe) of the --centering option being either "standard" (i.e. change nothing), "visual" (shifting -0.5 if the box is even to make it 'look' nice, maybe not so valuable for most cases), or "custom" with the option to specify values exactly as you suggest. This is next on my list!

#48
#46

Thanks for the feedback! All thoughts welcomed / are useful to consider if you disagree with this idea. (Am anticipating difficulties getting typer to like it, for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants